Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix content host finalizer #15186

Merged
merged 1 commit into from
May 28, 2024
Merged

Fix content host finalizer #15186

merged 1 commit into from
May 28, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented May 27, 2024

Problem Statement

The test_positive_check_ignore_facts_os_setting fails in teardown with

failed on teardown with "TypeError: set_ignore_facts_for_os() missing 1 required positional argument: 'module_target_sat'"

Solution

This PR, hopefully.

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/ui/test_contenthost.py -k test_positive_check_ignore_facts_os_setting

@vsedmik vsedmik added CherryPick PR needs CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels May 27, 2024
@vsedmik vsedmik self-assigned this May 27, 2024
@vsedmik vsedmik requested a review from a team as a code owner May 27, 2024 15:52
@vsedmik
Copy link
Contributor Author

vsedmik commented May 27, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_contenthost.py -k test_positive_check_ignore_facts_os_setting

Griffin-Sullivan
Griffin-Sullivan approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack pending PRT

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7130
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_contenthost.py -k test_positive_check_ignore_facts_os_setting --external-logging
Test Result : =========== 30 deselected, 38 warnings, 1 error in 722.33s (0:12:02) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label May 28, 2024
@vsedmik
Copy link
Contributor Author

vsedmik commented May 28, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_contenthost.py -k test_positive_check_ignore_facts_os_setting
nailgun: 1151

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7133
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_contenthost.py -k test_positive_check_ignore_facts_os_setting --external-logging
Test Result : ========== 1 passed, 30 deselected, 44 warnings in 960.18s (0:16:00) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels May 28, 2024
@Griffin-Sullivan Griffin-Sullivan merged commit 121a3d8 into SatelliteQE:master May 28, 2024
15 checks passed
github-actions bot pushed a commit that referenced this pull request May 28, 2024
@vsedmik @web-flow
Fix content host finalizer (#15186)
4298fbc 
(cherry picked from commit 121a3d8)
github-actions bot pushed a commit that referenced this pull request May 28, 2024
@vsedmik @web-flow
Fix content host finalizer (#15186)
7597252 
(cherry picked from commit 121a3d8)
This was referenced May 28, 2024
Merged
Merged
github-actions bot pushed a commit that referenced this pull request May 28, 2024
@vsedmik @web-flow
Fix content host finalizer (#15186)
bfde910 
(cherry picked from commit 121a3d8)
@Satellite-QE Satellite-QE mentioned this pull request May 28, 2024
Merged
vsedmik added a commit that referenced this pull request May 28, 2024
@Satellite-QE @vsedmik
[6.14.z] Fix content host finalizer (#15194)
b8760b9 
Fix content host finalizer (#15186)

(cherry picked from commit 121a3d8)

Co-authored-by: vsedmik <[email protected]>
vsedmik added a commit that referenced this pull request May 28, 2024
@Satellite-QE @vsedmik
[6.13.z] Fix content host finalizer (#15195)
68ac154 
Fix content host finalizer (#15186)

(cherry picked from commit 121a3d8)

Co-authored-by: vsedmik <[email protected]>
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@vsedmik @jyejare
Fix content host finalizer (SatelliteQE#15186)
009c835
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Griffin-Sullivan Griffin-Sullivan Griffin-Sullivan approved these changes

Assignees

@vsedmik vsedmik

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vsedmik @Satellite-QE @Griffin-Sullivan